Extended debug GL interface to render buffers

Extended debug GL interface to render buffers

[bsalomon, 2012-03-22 19:27:04]

http://codereview.appspot.com/5875050/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
File src/gpu/gl/GrGLCreateDebugInterface.cpp (right):

http://codereview.appspot.com/5875050/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
src/gpu/gl/GrGLCreateDebugInterface.cpp:593: {
nit: no newline

http://codereview.appspot.com/5875050/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
src/gpu/gl/GrGLCreateDebugInterface.cpp:916:
GrAlwaysAssert(GR_GL_COLOR_ATTACHMENT0 == attachment ||
Do we never use GL_DEPTH_STENCIL_ATTACHMENT anymore?  We used to but maybe
eliminated all such instances.

[robertphillips, 2012-03-22 20:13:09]

Addressed issues from first code review

http://codereview.appspot.com/5875050/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
File src/gpu/gl/GrGLCreateDebugInterface.cpp (right):

http://codereview.appspot.com/5875050/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
src/gpu/gl/GrGLCreateDebugInterface.cpp:593: {
On 2012/03/22 19:27:04, bsalomon wrote:
> nit: no newline

Done.

http://codereview.appspot.com/5875050/diff/1/src/gpu/gl/GrGLCreateDebugInterf...
src/gpu/gl/GrGLCreateDebugInterface.cpp:916:
GrAlwaysAssert(GR_GL_COLOR_ATTACHMENT0 == attachment ||
When we detect packed depth/stencil buffers are supported we create the render
buffer storage with a different format and call framebufferrenderbuffer twice
attaching the same buffer the the depth buffer and stencil buffer.
GL_DEPTH_STENCIL_ATTACHMENT is supported in full OpenGL - not so sure about ES.

[TomH, 2012-03-22 20:16:56]

Yeah, we had an emergency last year where we had to change things to do GL_DEPTH
+ GL_STENCIL instead of GL_DEPTH_STENCIL.

[bsalomon, 2012-03-22 20:20:31]

On 2012/03/22 20:16:56, TomH wrote:
> Yeah, we had an emergency last year where we had to change things to do
GL_DEPTH
> + GL_STENCIL instead of GL_DEPTH_STENCIL.

That's right. Well LGTM to me then.

[robertphillips, 2012-03-22 20:21:46]

Any issues w/ removing the GL_DEPTH_STENCIL #define from GrGLDefines.h?

On Thu, Mar 22, 2012 at 4:20 PM, <bsalomon@google.com> wrote:

> On 2012/03/22 20:16:56, TomH wrote:
>
>> Yeah, we had an emergency last year where we had to change things to
>>
> do GL_DEPTH
>
>> + GL_STENCIL instead of GL_DEPTH_STENCIL.
>>
>
> That's right. Well LGTM to me then.
>
>
http://codereview.appspot.com/**5875050/<http://codereview.appspot.com/5875050/>
>

[bsalomon, 2012-03-22 20:25:04]

I think we just want to remove GR_GL_DEPTH_STENCIL_ATTACHMENT not
GR_GL_DEPTH_STENCIL, right?

On Thu, Mar 22, 2012 at 4:21 PM, Robert Phillips
<robertphillips@google.com>wrote:

> Any issues w/ removing the GL_DEPTH_STENCIL #define from GrGLDefines.h?
>
>
> On Thu, Mar 22, 2012 at 4:20 PM, <bsalomon@google.com> wrote:
>
>> On 2012/03/22 20:16:56, TomH wrote:
>>
>>> Yeah, we had an emergency last year where we had to change things to
>>>
>> do GL_DEPTH
>>
>>> + GL_STENCIL instead of GL_DEPTH_STENCIL.
>>>
>>
>> That's right. Well LGTM to me then.
>>
>>
http://codereview.appspot.com/**5875050/<http://codereview.appspot.com/5875050/>
>>
>
>

[robertphillips, 2012-03-22 20:49:49]

committed as r3469