Issue 5874056: Remove circular dependency of views and animator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5874056: Remove circular dependency of views and animator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bungeman

Modified:
12 years, 6 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Remove circular dependency of views and animator.

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -2211 lines)			Patch
M	gyp/SampleApp.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/animator.gyp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gyp/views.gyp	View	1 2	6 chunks	+6 lines, -26 lines	0 comments	Download
A	gyp/views_animated.gyp	View	1 2	1 chunk	+74 lines, -0 lines	0 comments	Download
D	include/views/SkWidgetViews.h	View	1 2	1 chunk	+0 lines, -305 lines	0 comments	Download
D	src/views/SkBorderView.cpp	View	1 2	1 chunk	+0 lines, -96 lines	0 comments	Download
D	src/views/SkImageView.cpp	View	1 2	1 chunk	+0 lines, -303 lines	0 comments	Download
D	src/views/SkListWidget.cpp	View	1 2	1 chunk	+0 lines, -630 lines	0 comments	Download
D	src/views/SkProgressBarView.cpp	View	1 2	1 chunk	+0 lines, -109 lines	0 comments	Download
D	src/views/SkScrollBarView.cpp	View	1 2	1 chunk	+0 lines, -146 lines	0 comments	Download
D	src/views/SkStaticTextView.cpp	View	1 2	1 chunk	+0 lines, -184 lines	0 comments	Download
D	src/views/SkWidgetViews.cpp	View	1 2	1 chunk	+0 lines, -412 lines	0 comments	Download

Total messages: 5

bungeman

With this change there are no more circular dependencies between the static libraries.

12 years, 6 months ago (2012-03-22 20:57:08 UTC) #1

epoger

I will agree to this change IF you add comments to the top of views.gyp, ...

12 years, 6 months ago (2012-03-22 21:27:59 UTC) #2

bungeman

Moved everything to views/animated instead of animator_views since this seems (after some sleep) a better ...

12 years, 6 months ago (2012-03-23 13:57:29 UTC) #3

Committed revision 3473.