make skdiff count the missing pictures

make skdiff count the missing pictures

complete the bug on skia list and remove the todo item in the comment.

BUG=http://code.google.com/p/skia/issues/detail?id=489
TEST=A is a superset of B; B is a superset of A; both directories have missing files; identically.

[guanqun, 2012-03-22 15:40:52]

please review. thanks! Any changes to the output?

[epoger, 2012-03-22 15:48:24]

Thanks for submitting this!

Tom- I'm going to patch this into a local client and see how it runs.  Perhaps
you could take a look at the code and see if it is to your liking?

[epoger, 2012-03-22 16:07:46]

The results look good on my Linux machine.

I think it might be good to add a list of the missing files at the TOP of the
output (just the list shouldn't take up too much visual room, and missing files
are arguably 100% pixel different).  But improvements like that can come later.

Tom, please let me know if you will have time to look at the code (since you
originally wrote it), or if I should do it.  And come to my desk if you'd like
to see the output.

[TomH, 2012-03-22 18:14:17]

LGTM. I'll go ahead and land this?

http://codereview.appspot.com/5874051/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/5874051/diff/1/tools/skdiff_main.cpp#newcode881
tools/skdiff_main.cpp:881: print_diff_with_missing_file(&outputStream, *diff,
relativePath);
It isn't at all clear to me that we want to do this, but Elliot argues that it's
good.

[epoger, 2012-03-22 18:20:51]

landed as http://code.google.com/p/skia/source/detail?r=3468

Thanks, guanqun!