Issue 5874045: code review 5874045: exp/norm/normalize.go: fix typo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5874045: code review 5874045: exp/norm/normalize.go: fix typo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by gri

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, r, dsymonds

Visibility:
Public.

Patch Set 2 : diff -r 16c3175a5da1 https://code.google.com/p/go #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/exp/norm/normalize.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 1 month ago (2012-03-21 21:50:11 UTC) #1

LGTM http://codereview.appspot.com/5874045/diff/1/src/pkg/exp/norm/normalize.go File src/pkg/exp/norm/normalize.go (right): http://codereview.appspot.com/5874045/diff/1/src/pkg/exp/norm/normalize.go#newcode359 src/pkg/exp/norm/normalize.go:359: if p == 0 { // starts with ...

12 years, 1 month ago (2012-03-21 21:52:59 UTC) #2

gri

12 years, 1 month ago (2012-03-21 21:55:09 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c901fddcc4cb ***

exp/norm/normalize.go: fix typo

R=golang-dev, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/5874045

Expand All Messages | Collapse All Messages