Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 5871: making this class final, it should not need to be overridden (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by danny.antonetti
Modified:
14 years, 9 months ago
Reviewers:
Max Ross
CC:
hibernate-shards-dev_googlegroups.com
Base URL:
http://anonsvn.jboss.org/repos/hibernate/shards/trunk/src/java/org/hibernate/shards/strategy/selection/
Visibility:
Public.

Description

This was the resolution that was decided in the bug http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51 j

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
ShardResolutionStrategyDataImpl.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
danny.antonetti
This was the fix addressing the following bug http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51
15 years, 7 months ago (2008-09-17 03:20:00 UTC) #1
Max Ross
LGTM
15 years, 7 months ago (2008-09-17 15:48:35 UTC) #2
Max Ross
15 years, 7 months ago (2008-09-17 15:59:39 UTC) #3
On 2008/09/17 15:48:35, Max Ross wrote:
> LGTM

CL submitted, please mark this issue as closed.

Thanks!

Max
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b