Utils must not depend on Views.

Utils must not depend on Views.

[bungeman, 2012-03-21 18:59:15]

I've been taking a look at the dependencies between the libraries we build in
Skia, and the unintentional dependency of utils on views was the most glaring.
This change removes that dependency by moving all of the OSWindow and associated
UI out of utils and into views. Note that the patches created by svn here show
only the deletes. All deletes here are actually moves, just imagine that all
'/utils/' here are replaced by '/views/'.

[epoger, 2012-03-21 19:07:41]

Looks fine to me, although it's not clear to me exactly what should be in views/
and what should be in utils/ anyway...

http://codereview.appspot.com/5867051/diff/1029/gyp/SampleApp.gyp
File gyp/SampleApp.gyp (right):

http://codereview.appspot.com/5867051/diff/1029/gyp/SampleApp.gyp#newcode178
gyp/SampleApp.gyp:178: '../src/views/mac/SampleAppDelegate.h',
Since these files are SampleApp-specific, shouldn't they go somewhere else? 
(This was already broken when you found it, though, so OK to fix it later I
suppose.)

[bungeman, 2012-03-21 19:17:23]

On 2012/03/21 19:07:41, epoger wrote:
> Looks fine to me, although it's not clear to me exactly what should be in
views/
> and what should be in utils/ anyway...
> 
> http://codereview.appspot.com/5867051/diff/1029/gyp/SampleApp.gyp
> File gyp/SampleApp.gyp (right):
> 
> http://codereview.appspot.com/5867051/diff/1029/gyp/SampleApp.gyp#newcode178
> gyp/SampleApp.gyp:178: '../src/views/mac/SampleAppDelegate.h',
> Since these files are SampleApp-specific, shouldn't they go somewhere else? 
> (This was already broken when you found it, though, so OK to fix it later I
> suppose.)

Yeah, I didn't know either before this. Core, opts, opts_ssse3, ports, and utils
can be considered co-dependent and should be one 'skia.a' (which is on my todo
list). This 'skia.a' should not depend on anything else in Skia. Views is
designed to support SampleApp and generally be an example of how to use Skia to
do UI on a given platform. It can pretty much depend on whatever (and generally
does).

The SampleApp specific ones probably should be moved to SampleApp, but I'd
rather do that later as that would make this change even more difficult.

The current situation without this change is that core.a requires animator.a in
order to link and this causes a large circular link dependency.

[epoger, 2012-03-21 19:36:20]

LGTM

On 2012/03/21 19:17:23, bungeman wrote:
> On 2012/03/21 19:07:41, epoger wrote:
> > Looks fine to me, although it's not clear to me exactly what should be in
> views/
> > and what should be in utils/ anyway...
> > 
> > http://codereview.appspot.com/5867051/diff/1029/gyp/SampleApp.gyp
> > File gyp/SampleApp.gyp (right):
> > 
> > http://codereview.appspot.com/5867051/diff/1029/gyp/SampleApp.gyp#newcode178
> > gyp/SampleApp.gyp:178: '../src/views/mac/SampleAppDelegate.h',
> > Since these files are SampleApp-specific, shouldn't they go somewhere else? 
> > (This was already broken when you found it, though, so OK to fix it later I
> > suppose.)
> 
> Yeah, I didn't know either before this. Core, opts, opts_ssse3, ports, and
utils
> can be considered co-dependent and should be one 'skia.a' (which is on my todo
> list). This 'skia.a' should not depend on anything else in Skia. Views is
> designed to support SampleApp and generally be an example of how to use Skia
to
> do UI on a given platform. It can pretty much depend on whatever (and
generally
> does).

"One 'skia.a'", you say?  Feel free to add yourself to
http://code.google.com/p/skia/issues/detail?id=459 ('No option is provided to
build Skia as a standalone library'), or tie it to any related action item...

[bungeman, 2012-03-21 21:21:32]

Committed revision 3459.