Issue 5864044: Move SkClampRange.h out of include/core

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5864044: Move SkClampRange.h out of include/core (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by TomH

Modified:
12 years, 3 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

A while ago we made a note that SkClampRange didn't need to be public in include/core/, and it should live in src/core/. However, the one place it's used is in effects/core/ (well, and tests/). This means we can: 1) move it to effects/core/ 2) move it to src/core/, and have gyp/effects.gyp #include src/core/. 3) leave it where it is and get rid of the trivial TODO item

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -207 lines)			Patch
M	gyp/core.gyp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	gyp/effects.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gyp/tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	include/core/SkClampRange.h	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	src/core/SkClampRange.cpp	View	1 chunk	+0 lines, -166 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

I can't see where they are being moved to, but I'm sure its right :) ...

12 years, 3 months ago (2012-03-20 21:18:10 UTC) #2

Closed with r3445.

Expand All Messages | Collapse All Messages