Issue 5864: * Fix #498.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5864: * Fix #498. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by hanwenn

Modified:
13 years, 2 months ago

Reviewers:
joeneeman

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Add a priority queue with pending ties.

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -11 lines)			Patch
	A	input/regression/completion-heads-tie.ly	View		1 chunk	+18 lines, -0 lines	0 comments	Download
	M	lily/completion-note-heads-engraver.cc	View		9 chunks	+73 lines, -11 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

joeneeman

15 years, 7 months ago (2008-09-18 20:56:10 UTC) #1

LGTM

http://codereview.appspot.com/5864/diff/1/3
File lily/completion-note-heads-engraver.cc (right):

http://codereview.appspot.com/5864/diff/1/3#newcode17
Line 17: #include "pqueue.hh"
Huh, I never knew we had a priority queue

Expand All Messages | Collapse All Messages