Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(623)

Issue 58610044: Improve positioning of tuplet numbers for kneed beams.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by david.nalesnik
Modified:
10 years, 2 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Improve positioning of tuplet numbers for kneed beams. In the past LilyPond always placed tuplet numbers according to the position of a bracket, though this bracket may or may not have actually been drawn. This system led at times to tuplet numbers which appeared stranded when there was a kneed beam and no visible bracket. This patch positions the tuplet number independently of brackets and close to the beam when the the bracket is not drawn, the beam is kneed, and there is an appropriate beam segment to place the number against. The side of the beam on which the number is placed is chosen by principles derived from Gould. The number is centered horizontally on the beam. Collision detection is also introduced. The number will be offset horizontally if it is too close to an adjoining note column. All shifts preserve the number's vertical distance from the beam. If the number is too large to fit in the available horizontal space (between note columns to either side), we use the old bracket-based positioning system. In the event of a collision with an accidental, the tuplet number is moved vertically, away from the beam. The older behavior is always available through an override of the property `knee-to-beam' which is introduced by this patch, and set by default to true. This patch also adds a header file, `tuplet-number.hh', and provides a regression test, `tuplet-numbers-kneed-beams.ly'.

Patch Set 1 #

Patch Set 2 : extra line removed #

Patch Set 3 : no numbers between staff and beam #

Patch Set 4 : slight reordering #

Patch Set 5 : more with accidentals #

Patch Set 6 : more regtests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+690 lines, -14 lines) Patch
A input/regression/tuplet-number-french-kneed-beams.ly View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download
A input/regression/tuplet-number-kneed-beam-even-stem-count.ly View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A input/regression/tuplet-number-kneed-beam-horizontal-fit.ly View 1 2 3 4 5 1 chunk +30 lines, -0 lines 0 comments Download
A input/regression/tuplet-number-kneed-beam-ledger-lines.ly View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
A input/regression/tuplet-number-shift-along-kneed-beam.ly View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A input/regression/tuplet-numbers-kneed-beams.ly View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
A input/regression/tuplet-numbers-kneed-beams-accidentals.ly View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A lily/include/tuplet-number.hh View 1 chunk +43 lines, -0 lines 0 comments Download
M lily/tuplet-number.cc View 1 2 3 4 3 chunks +416 lines, -14 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
janek
Why are there so few test cases in the regtests? I saw that you have ...
10 years, 2 months ago (2014-02-06 21:44:26 UTC) #1
david.nalesnik
On 2014/02/06 21:44:26, janek wrote: > Why are there so few test cases in the ...
10 years, 2 months ago (2014-02-08 21:45:33 UTC) #2
janek
this ROCKS! What about "more than 1 tuplet per beam group" and "nested tuplets"? My ...
10 years, 2 months ago (2014-02-09 21:23:29 UTC) #3
david.nalesnik
On 2014/02/09 21:23:29, janek wrote: > this ROCKS! :) > > What about "more than ...
10 years, 2 months ago (2014-02-09 22:43:34 UTC) #4
janek
10 years, 2 months ago (2014-02-09 22:48:41 UTC) #5
2014-02-09 23:43 GMT+01:00  <david.nalesnik@gmail.com>:
> The "more than 1 tuplet per beam group" is actually covered by the
> French beaming example.

ok.  sorry for not looking carefully enough (too hasty...)

> I could include the nested tuplet stuff, but would you have any
> objection to adding it later, after this patch is through?  This is
> getting *huge*!

sure, no problem!

best,
j
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b