adding javadoc comments to the ShardStrategy

[danny.antonetti, 2008-09-13 19:01:02]

Adding Javadoc class comments to ShardStrategy

[Max Ross, 2008-09-13 22:10:33]

I've cc'ed hibernate-shards-dev@googlegroups.com on this email.  Let's add that
as a 'cc' for all future code reviews.

Great job getting this first review out so quickly!

Just a few small comments.

Thanks!
Max

http://codereview.appspot.com/5854/diff/1/2
File ShardStrategy.java (right):

http://codereview.appspot.com/5854/diff/1/2#newcode28
Line 28: * This class determines through {@link ShardAccessStrategy}, {@link
ShardResolutionStrategy},
and

http://codereview.appspot.com/5854/diff/1/2#newcode31
Line 31: *  <p>When given a query the {@link ShardAccessStrategy} will determine
which order to look for the shards on, or the
will determine how the query will be distributed across the known shards - in
sequence, in parallel, or some combination of the two.

[danny.antonetti, 2008-09-13 22:52:39]

updating doc with Max's clarifications

How do I actually commit?

I have been using the read only svn repository, I dont have an account to the
dev repository yet.

[Max Ross, 2008-09-13 23:12:17]

On 2008/09/13 22:52:39, danny.antonetti wrote:
> updating doc with Max's clarifications
> 
> How do I actually commit?
> 
> I have been using the read only svn repository, I dont have an account to the
> dev repository yet.

LGTM (looks good to me)

So far I'm really happy about your enthusiasm and responsiveness Danny, but I'd
like to see a couple of meaningful code changes before I give you commit access
on the project.  Until then, please send me a patch with your changes and I'll
submit on your behalf.

Thanks!