Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1119)

Issue 5848056: Sets lilypond-id message to type progress (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by PhilEHolmes
Modified:
12 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

We're now down to about 460 lines of output from make doc -s, and "lilypond-book.py (GNU LilyPond) 2.15.34" is nearly 20% of them. If the way this is output is changed to progress(), then running -book with -l WARN (which we do) does not output these to terminal. Please review whether this is the best approach.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M scripts/lilypond-book.py View 1 chunk +2 lines, -3 lines 1 comment Download

Messages

Total messages: 6
PhilEHolmes
Please review
12 years ago (2012-03-18 17:34:47 UTC) #1
Graham Percival
http://codereview.appspot.com/5848056/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (right): http://codereview.appspot.com/5848056/diff/1/scripts/lilypond-book.py#newcode104 scripts/lilypond-book.py:104: progress(_ ('%s (GNU LilyPond) %s' % (ly.program_name, ly.program_version))) LGTM. ...
12 years ago (2012-03-18 17:49:35 UTC) #2
Reinhold
LGTM
12 years ago (2012-03-18 18:00:38 UTC) #3
Julien Rioux
On Sun, Mar 18, 2012 at 1:49 PM, <graham@percival-music.ca> wrote: > > http://codereview.appspot.com/5848056/diff/1/scripts/lilypond-book.py > File ...
12 years ago (2012-03-18 18:19:08 UTC) #4
email_philholmes.net
----- Original Message ----- From: "Julien Rioux" <julien.rioux@gmail.com> To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>; <julien.rioux@gmail.com>; <dak@gnu.org>; <reinhold.kainhofer@gmail.com>; <lilypond-devel@gnu.org>; ...
12 years ago (2012-03-18 18:31:13 UTC) #5
Jean-Charles
12 years ago (2012-03-18 18:40:04 UTC) #6
Le 18/03/2012 19:31, Phil Holmes disait :
>>>
http://codereview.appspot.com/5848056/diff/1/scripts/lilypond-book.py#newcode104
>>>
>>> scripts/lilypond-book.py:104: progress(_ ('%s (GNU LilyPond) %s' %
>>> (ly.program_name, ly.program_version)))
>>
>> We don't need the _ (), we don't translate that string.
>> Julien
>
> Never understood what that was for - just copied other examples. It's to
> do with translations, then?
>

It is explained in CG-10.5.8 Localization.

Cheers,
Jean-Charles
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b