Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2014)

Issue 5846050: Add __version__ to each library. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by jcgregorio_google
Modified:
12 years, 5 months ago
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

Moves version info into the modules where it will be accessible at run time. Useful for debugging.

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : fix __import__ #

Patch Set 4 : rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M Makefile View 1 2 2 chunks +4 lines, -17 lines 0 comments Download
M apiclient/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M oauth2client/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A runtests.sh View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M setup.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M setup_oauth2client.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7
jcgregorio_google
ping
12 years, 5 months ago (2012-03-20 21:39:34 UTC) #1
aiuto
Looks find but I am curious about the __import__() http://codereview.appspot.com/5846050/diff/2001/setup.py File setup.py (right): http://codereview.appspot.com/5846050/diff/2001/setup.py#newcode50 setup.py:50: ...
12 years, 5 months ago (2012-03-20 21:47:08 UTC) #2
jcgregorio_google
On 2012/03/20 21:47:08, aiuto wrote: > Looks find but I am curious about the __import__() ...
12 years, 5 months ago (2012-03-21 17:43:38 UTC) #3
aiuto
>... Switched to import. ? Now it looks like no import at all. In patch ...
12 years, 5 months ago (2012-03-21 18:23:39 UTC) #4
jcgregorio_google
Rebased the diffs. PTAL. On 2012/03/21 18:23:39, aiuto wrote: > >... Switched to import. > ...
12 years, 5 months ago (2012-03-21 18:31:23 UTC) #5
aiuto
lgtm
12 years, 5 months ago (2012-03-21 19:15:45 UTC) #6
jcgregorio_google
12 years, 5 months ago (2012-03-21 19:24:55 UTC) #7
On 2012/03/21 19:15:45, aiuto wrote:
> lgtm

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=fc1578d8591...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b