Issue 5846046: Skip unnecessary copies in GrPaint operator ==

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5846046: Skip unnecessary copies in GrPaint operator == (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	include/gpu/GrPaint.h	View		1 chunk	+12 lines, -6 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

Good for 4% improvement on the txt picture playback benches on the mac

12 years, 7 months ago (2012-03-16 15:57:36 UTC) #1

TomH

http://codereview.appspot.com/5846046/diff/1/include/gpu/GrPaint.h File include/gpu/GrPaint.h (right): http://codereview.appspot.com/5846046/diff/1/include/gpu/GrPaint.h#newcode145 include/gpu/GrPaint.h:145: } We don't need to worry about setting fTextureSamplers[i] ...

12 years, 7 months ago (2012-03-16 15:58:45 UTC) #2

bsalomon

12 years, 7 months ago (2012-03-16 17:09:40 UTC) #3

Landed r3417

Expand All Messages | Collapse All Messages