Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1105)

Issue 5845068: patch to debug GL interface to address Linux warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by robertphillips
Modified:
12 years, 8 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

patch to debug GL interface to address Linux warnings changed the buffer pointer to a char * and disable irrelevant assert

Patch Set 1 #

Patch Set 2 : Performed 2 other compiler silencing tasks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M include/core/SkPaint.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCreateDebugInterface.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
robertphillips
12 years, 8 months ago (2012-03-19 15:55:11 UTC) #1
TomH
LGTM
12 years, 8 months ago (2012-03-19 16:14:25 UTC) #2
robertphillips
committed as r3428
12 years, 8 months ago (2012-03-19 16:20:22 UTC) #3
robertphillips
Here is the next version. Elliot is also stumped as to why there is a ...
12 years, 8 months ago (2012-03-21 19:30:53 UTC) #4
robertphillips
12 years, 8 months ago (2012-03-21 19:31:02 UTC) #5
TomH
12 years, 8 months ago (2012-03-21 19:33:21 UTC) #6
It looks like our make clean step really is doing everything we need it to.
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b