Issue 5845068: patch to debug GL interface to address Linux warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5845068: patch to debug GL interface to address Linux warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by robertphillips

Modified:
12 years, 3 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

patch to debug GL interface to address Linux warnings changed the buffer pointer to a char * and disable irrelevant assert

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
M	include/core/SkPaint.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLCreateDebugInterface.cpp	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/utils/SkDumpCanvas.cpp	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 6

robertphillips

Here is the next version. Elliot is also stumped as to why there is a ...

12 years, 3 months ago (2012-03-21 19:30:53 UTC) #4

TomH

12 years, 3 months ago (2012-03-21 19:33:21 UTC) #6

It looks like our make clean step really is doing everything we need it to.
LGTM.