Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(242)

Issue 5843050: SSE2 accelerated opaque blitRect (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by TomH
Modified:
12 years, 8 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Trying to make progress on a task we'd talked about and then parked months ago. (The blurs look less than feasible, although we could look at what's going wrong there.) The chrome_scrollGmail benchmark was originally developed for this. The patch produces a 7% overall speedup; dividing the benchmark into narrow (< 31 px) and wide cases, it yields 15% on narrow rects, 5% on wide.

Patch Set 1 #

Patch Set 2 : SSE2 accelerated procs #

Patch Set 3 : Suggested merge of SkBlitRect into SkBlitRow #

Patch Set 4 : Clean up stale #includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -11 lines) Patch
M gyp/opts.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBlitRow.h View 1 2 3 chunks +18 lines, -7 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A src/opts/SkBlitRect_opts_SSE2.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A src/opts/SkBlitRect_opts_SSE2.cpp View 1 2 1 chunk +133 lines, -0 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3
TomH
This version speeds up: 20%: path_fill_big_rect, rects_1, rects_1_stroke_4 10%: rects_3_stroke_4
12 years, 8 months ago (2012-03-16 20:32:20 UTC) #1
TomH
Got rid of new headers, merged into SkBlitRow w/ a ColorRect32() sitting alongside Color32(). Similar ...
12 years, 8 months ago (2012-03-16 21:28:20 UTC) #2
TomH
12 years, 8 months ago (2012-03-19 13:50:57 UTC) #3
Committed in r3423.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b