Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(915)

Issue 5837046: Minor leak fixes and valgrind suppressions for tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by TomH
Modified:
12 years, 9 months ago
Reviewers:
epoger
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Two leaks left: http://code.google.com/p/skia/issues/detail?id=530 and one in RefDict. Several warnings about uninitialized data to go. This suppression turns off all warnings about things that go wrong in the drivers. One or two of those might be able to be traced back to user code.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Switch from explicit allocation to SkAutoMalloc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M tests/AAClipTest.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
A tests/valgrind.supp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5
TomH
12 years, 9 months ago (2012-03-15 17:56:28 UTC) #1
epoger
LGTM http://codereview.appspot.com/5837046/diff/1/tests/BitmapCopyTest.cpp File tests/BitmapCopyTest.cpp (right): http://codereview.appspot.com/5837046/diff/1/tests/BitmapCopyTest.cpp#newcode597 tests/BitmapCopyTest.cpp:597: delete [] buf; Is there not a good ...
12 years, 9 months ago (2012-03-15 18:04:41 UTC) #2
TomH
Skia avoids smart pointers; you'll find a few RefPointers, but only in the PDF code, ...
12 years, 9 months ago (2012-03-15 18:14:03 UTC) #3
epoger
On 2012/03/15 18:14:03, TomH wrote: > Skia avoids smart pointers; you'll find a few RefPointers, ...
12 years, 9 months ago (2012-03-15 18:15:16 UTC) #4
TomH
12 years, 9 months ago (2012-03-15 18:17:00 UTC) #5
Closed with r3406.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b