Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(279)

Issue 5833045: fix clang compilation warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by guanqun
Modified:
12 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

fix clang compilation warning -Wsign-compare ../src/gpu/gl/../GrDrawState.h:88:75: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare] sizeof(fSrcBlend) + sizeof(fDstBlend) + sizeof(GrMatrix) == ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ ../include/gpu/GrConfig.h:270:39: note: expanded from macro 'GrAssert' ^ ../include/gpu/GrConfig.h:261:54: note: expanded from macro 'GR_DEBUGASSERT' #define GR_DEBUGASSERT(COND) GR_ALWAYSASSERT(COND) ^ ../include/gpu/GrConfig.h:249:19: note: expanded from macro 'GR_ALWAYSASSERT' if (!(COND)) { \ ^~~~ ../tests/UnicodeTest.cpp:72:36: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int [-Wsign-compare] REPORTER_ASSERT(reporter, len8 == count8); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ ../tests/Test.h:116:15: note: expanded from macro 'REPORTER_ASSERT' if (!(cond)) { \ ^ ../tests/UnicodeTest.cpp:73:36: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int [-Wsign-compare] REPORTER_ASSERT(reporter, len8 == count16); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ../tests/Test.h:116:15: note: expanded from macro 'REPORTER_ASSERT' if (!(cond)) { \ ^ ../tests/UnicodeTest.cpp:74:36: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int [-Wsign-compare] REPORTER_ASSERT(reporter, len8 == count32); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ../tests/Test.h:116:15: note: expanded from macro 'REPORTER_ASSERT' if (!(cond)) { \ ^ BUG= TEST=

Patch Set 1 #

Patch Set 2 : two fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gpu/GrDrawState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/UnicodeTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6
guanqun
please review, thanks!
12 years, 6 months ago (2012-03-22 04:32:03 UTC) #1
reed1
UnicodeTest changes are fine. Leaving the Gr changes to Brian
12 years, 6 months ago (2012-03-22 12:39:00 UTC) #2
bsalomon
On 2012/03/22 12:39:00, reed1 wrote: > UnicodeTest changes are fine. Leaving the Gr changes to ...
12 years, 6 months ago (2012-03-22 13:03:37 UTC) #3
guanqun.lu_gmail.com
Please help land this CL. BTW: there are lots of clang warning in src/animator/ and ...
12 years, 6 months ago (2012-03-22 14:13:48 UTC) #4
reed1
animator is in flux right now -- best not to spend anytime tweaking it. On ...
12 years, 6 months ago (2012-03-22 14:16:14 UTC) #5
bsalomon
12 years, 6 months ago (2012-03-22 21:29:31 UTC) #6
On 2012/03/22 14:16:14, reed1 wrote:
> animator is in flux right now -- best not to spend anytime tweaking it.
> 
> On Thu, Mar 22, 2012 at 10:13 AM, Lu Guanqun <mailto:guanqun.lu@gmail.com>
wrote:
> 
> > Please help land this CL.
> >
> > BTW: there are lots of clang warning in src/animator/ and it complains
> > about subclass's add() function hides the overloaded functions.
> > 1. are these intended interfaces for subclasses?
> > 2. do we use animator code somewhere? That's why I'm not submitting
> > the fix here.
> >
> > --guanqun
> >
> > On Thu, Mar 22, 2012 at 9:03 PM,  <mailto:bsalomon@google.com> wrote:
> > > On 2012/03/22 12:39:00, reed1 wrote:
> > >>
> > >> UnicodeTest changes are fine. Leaving the Gr changes to Brian
> > >
> > >
> > > LGTM
> > >
> > > http://codereview.appspot.com/5833045/
> >
> >
> >
> > --
> > Guanqun
> >

Committed as r3472
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b