Issue 583200043: Issue 5636: fix various warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 583200043: Issue 5636: fix various warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 4 months ago by Dan Eble

Modified:
4 years, 4 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

https://sourceforge.net/p/testlilyissues/issues/5636/ 1: int->vsize in Cluster 2: int->vsize in Grob::pure_is_visible () Also, for maintainability, let Item::pure_is_visible () default to Grob::pure_is_visible () rather than use a hard-coded value. 3: more int->vsize in System Doesn't fix any warnings now, but will avoid new ones later. 4: int->long for result of scm_ilength ()

Patch Set 1 : int->vsize in Cluster #

Patch Set 2 : int->vsize in Grob::pure_is_visible () #

Patch Set 3 : more int->vsize in System #

Patch Set 4 : int->long for result of scm_ilength () #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -31 lines)			Patch
M	lily/cluster.cc	View		4 chunks	+13 lines, -8 lines	0 comments	Download
M	lily/dispatcher.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/general-scheme.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/grob.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	lily/include/grob.hh	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	lily/include/item.hh	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/include/system.hh	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	lily/item.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	lily/lily-guile.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/repeated-music.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/system.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/tab-staff-symbol-engraver.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM, thanks!  Fixing those warnings is a great job.

Expand All Messages | Collapse All Messages