Issue 583000043: Remove spurious '% begin verbatim' in Documentation/snippets/new

Issue 583000043: Remove spurious '% begin verbatim' in Documentation/snippets/new (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 6 months ago by dak

Modified:
4 years, 2 months ago

Reviewers:
benko.pal, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove spurious '% begin verbatim' in Documentation/snippets/new Also: Run scripts/auxiliar/makelsr.py

Patch Set 1 #

Total comments: 4

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -52 lines)			Patch
M	Documentation/snippets/adding-drum-parts.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/aiken-head-thin-variant-noteheads.ly	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/aligning-and-centering-instrument-names.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/automatic-fretboards-barre.ly	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Documentation/snippets/clip-systems.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/combining-two-parts-on-the-same-staff.ly	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/figured-bass-headword.ly	View	2 chunks	+2 lines, -2 lines	2 comments	Download
M	Documentation/snippets/heavily-customized-polymetric-time-signatures.ly	View	2 chunks	+2 lines, -2 lines	2 comments	Download
M	Documentation/snippets/horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/jazz-combo-template.ly	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/new/adding-drum-parts.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/aiken-head-thin-variant-noteheads.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/aligning-and-centering-instrument-names.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/automatic-fretboards-barre.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/clip-systems.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/combining-two-parts-on-the-same-staff.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/figured-bass-headword.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/heavily-customized-polymetric-time-signatures.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/jazz-combo-template.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/orchestra,-choir-and-piano-template.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/piano-template-simple.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/quoting-another-voice.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/quoting-another-voice-with-transposition.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/string-quartet-template-simple.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/string-quartet-template-with-separate-parts.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/turkish-makam-example.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/new/utf-8.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/snippets/orchestra,-choir-and-piano-template.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/piano-template-simple.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/quoting-another-voice.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/quoting-another-voice-with-transposition.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/string-quartet-template-simple.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/string-quartet-template-with-separate-parts.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/turkish-makam-example.ly	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/snippets/utf-8.ly	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benko.pal

LGTM https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/figured-bass-headword.ly File Documentation/snippets/figured-bass-headword.ly (right): https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/figured-bass-headword.ly#newcode35 Documentation/snippets/figured-bass-headword.ly:35: I guess there should be no empty line ...

4 years, 6 months ago (2019-09-24 07:42:28 UTC) #1

lemzwerg

LGTM, too. No need to add any further formatting right now. After finishing my indexing ...

4 years, 6 months ago (2019-09-24 08:49:17 UTC) #2

dak

4 years, 6 months ago (2019-09-25 23:01:21 UTC) #3

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippet...
File Documentation/snippets/figured-bass-headword.ly (right):

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippet...
Documentation/snippets/figured-bass-headword.ly:35: 
On 2019/09/24 07:42:27, benko.pal wrote:
> I guess there should be no empty line at all here

All other \with blocks have the same silly empty line, so there is no point in
changing this particular occurence in connection with % begin verbatim while
leaving all the others.

Feel free to reformat in a different issue.  Needs doing so in
Documentation/snippets/new if you want to do it.

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippet...
File Documentation/snippets/heavily-customized-polymetric-time-signatures.ly
(right):

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippet...
Documentation/snippets/heavily-customized-polymetric-time-signatures.ly:39: \new
Staff \with {
On 2019/09/24 07:42:28, benko.pal wrote:
> indentation unneeded in this block

Separate independent format issue.  Worth fixing, but not really connected to
this issue.

Expand All Messages | Collapse All Messages