Issue 5824056: Fix GrDrawState memory comparison

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5824056: Fix GrDrawState memory comparison (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by TomH

Modified:
12 years, 5 months ago

Reviewers:
bsalomon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

GrDrawState compares bytes to see if two objects are equal. This means that everything it includes really needs to be zero when it's supposed to be zero. We achieve this by expanding the type mask in SkMatrix from int8 to int32, getting rid of uninitialized padding. Incidentally, this was skia issue 354, which I'd marked as WontFix but doesn't hurt to fix. This passes gm/bench on Linux and fixes the Valgrind uninitialized warnings.