Change SupplementalBranding from wchar_t to char.

Change SupplementalBranding from wchar_t to char.

BUG=none
TEST=none

[thakis, 2012-03-16 00:37:29]

As discussed over email.

I have some minor local changes I'm mentioning below (I'm writing this email on
a windows box, but uploaded the patch on a mac). Everything seems to work, tests
pass, etc. Chromium will need minor changes once it rolls to this revision.

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc
File lib/lib_values.cc (right):

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc#newcode12
lib/lib_values.cc:12: #if defined(OS_WIN)
also needs an #include "base/utf_string_conversions.h"

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc#newcode47
lib/lib_values.cc:47: SupplementaryBranding::SupplementaryBranding(const
wchar_t* brand)
needs to be char

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc#newcode49
lib/lib_values.cc:49: if (!lock_->store())
s/store/GetStore/, also once more below

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc#newcode73
lib/lib_values.cc:73: std::wstring*
wide_brand(ASCIIToUTF16(SupplementaryBranding::GetBrand()));
I changed this to UTF8ToUTF16

[Roger Tawa (Google), 2012-03-16 13:32:27]

lgtm

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc
File lib/lib_values.cc (right):

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc#newcode73
lib/lib_values.cc:73: std::wstring*
wide_brand(ASCIIToUTF16(SupplementaryBranding::GetBrand()));
On 2012/03/16 00:37:29, thakis wrote:
> I changed this to UTF8ToUTF16

Note that brands are a subset of ascii, so its fine to assume that instead of
utf8.

[thakis, 2012-03-16 14:28:52]

thanks!

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc
File lib/lib_values.cc (right):

http://codereview.appspot.com/5823061/diff/1/lib/lib_values.cc#newcode73
lib/lib_values.cc:73: std::wstring*
wide_brand(ASCIIToUTF16(SupplementaryBranding::GetBrand()));
On 2012/03/16 13:32:27, rogerta wrote:
> On 2012/03/16 00:37:29, thakis wrote:
> > I changed this to UTF8ToUTF16
> 
> Note that brands are a subset of ascii, so its fine to assume that instead of
> utf8.

Ok, then I'll leave this at ASCIIToUTF16.

[thakis, 2012-03-16 14:32:47]

Urgh, I landed this through `git svn dcommit`, which landed all my local commits
instead of squashing them! I should've used `git cl dcommit` instead. r90, r91,
r92 are all this change.