Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(840)

Issue 5821053: Perform degenerate check in device coords in convex path renderer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by bsalomon
Modified:
12 years, 9 months ago
Reviewers:
TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : use SkPackARGB32 and fix copyright date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -3 lines) Patch
A gm/base-win/bigmatrix_4444.png View Binary file 0 comments Download
A gm/base-win/bigmatrix_565.png View Binary file 0 comments Download
A gm/base-win/bigmatrix_8888.png View Binary file 0 comments Download
A gm/base-win/bigmatrix_gpu.png View Binary file 0 comments Download
A gm/bigmatrix.cpp View 1 1 chunk +97 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3
bsalomon
The convex path renderer checks for point / line degenerate paths. Currently, it does this ...
12 years, 9 months ago (2012-03-14 21:28:37 UTC) #1
TomH
LGTM. I can't construct a failure case this would miss...
12 years, 9 months ago (2012-03-15 13:58:20 UTC) #2
bsalomon
12 years, 9 months ago (2012-03-15 14:41:37 UTC) #3
Closed with r3401
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b