Issue 581800043: Fix translation-status.py with Python 3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 581800043: Fix translation-status.py with Python 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 1 month ago by hahnjo

Modified:
3 years, 12 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix translation-status.py with Python 3 Individual commits: 1) translations-status: Use str.maketrans() It's now a static function of the builtin type str, not in the string module. It wasn't marked as deprecated in Python 2... 2) translations-status: Call locals() outside of list comprehension Otherwise Python 3 throws KeyErrors because it's not getting the local variables from the function (in particular p). 3) translations-status: Correctly reference self.filename

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	scripts/auxiliar/translations-status.py	View		8 chunks	+11 lines, -9 lines	0 comments	Download