Issue 581700043: Replace file-cookie and memory-stream

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 581700043: Replace file-cookie and memory-stream (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by hahnjo

Modified:
4 years ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Replace file-cookie and memory-stream ttf: Replace Memory_out_stream by ostringstream

Patch Set 2 : fix style #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -340 lines)			Patch
M	config.hh.in	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	configure.ac	View		1 chunk	+1 line, -1 line	0 comments	Download
D	flower/file-cookie.cc	View		1 chunk	+0 lines, -55 lines	0 comments	Download
D	flower/include/file-cookie.hh	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	flower/include/memory-stream.hh	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	flower/memory-stream.cc	View		1 chunk	+0 lines, -131 lines	0 comments	Download
M	lily/pfb.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/pfb-scheme.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/ttf.cc	View	1	11 chunks	+62 lines, -65 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lemzwerg

LGTM, thanks! https://codereview.appspot.com/581700043/diff/569410044/lily/ttf.cc File lily/ttf.cc (right): https://codereview.appspot.com/581700043/diff/569410044/lily/ttf.cc#newcode95 lily/ttf.cc:95: I think the second empty line can ...

4 years, 2 months ago (2020-02-25 17:53:21 UTC) #1

hahnjo

4 years, 2 months ago (2020-02-25 19:06:40 UTC) #3

https://codereview.appspot.com/581700043/diff/569410044/lily/ttf.cc
File lily/ttf.cc (right):

https://codereview.appspot.com/581700043/diff/569410044/lily/ttf.cc#newcode95
lily/ttf.cc:95: 
On 2020/02/25 17:53:20, lemzwerg wrote:
> I think the second empty line can be removed.

Done.

https://codereview.appspot.com/581700043/diff/569410044/lily/ttf.cc#newcode207
lily/ttf.cc:207: stream << std::endl << " 00>" << std::endl << " <";
On 2020/02/25 17:53:20, lemzwerg wrote:
> for improved readability I suggest to always start a new line after
'std::endl'.

Done.

Expand All Messages | Collapse All Messages