Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1116)

Issue 5798047: runtime: improve interface conversion performance

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dfc
Modified:
11 years, 11 months ago
Reviewers:
r, minux1
CC:
golang-dev
Visibility:
Public.

Description

runtime: improve interface conversion performance Depends on CL 5777048. 2011 Mac Mini, Core i5, OS X Lion benchmark old ns/op new ns/op delta BenchmarkConvT2E 31 13 -58.06% BenchmarkConvT2I 30 24 -18.60% BenchmarkConvI2E 5 4 -6.69% BenchmarkConvI2I 19 18 -7.18% BenchmarkAssertE2T 14 13 -4.93% BenchmarkAssertE2I 21 19 -5.71% BenchmarkAssertI2T 14 13 -4.79% BenchmarkAssertI2I 20 20 -0.98% BenchmarkAssertI2E 21 19 -8.37% Ancient ARMv5 ~ 1.2Ghz benchmark old ns/op new ns/op delta BenchmarkConvT2E 345 156 -54.78% BenchmarkConvT2I 1025 826 -19.41% BenchmarkConvI2E 63 55 -12.76% BenchmarkConvI2I 732 724 -1.09% BenchmarkAssertE2T 164 164 +0.00% BenchmarkAssertE2I 758 761 +0.40% BenchmarkAssertI2T 171 171 +0.00% BenchmarkAssertI2I 760 763 +0.39% BenchmarkAssertI2E 760 758 -0.26%

Patch Set 1 #

Patch Set 2 : diff -r 3355c03e3e2c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 047d46024b74 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 734071724054 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 40632db23c46 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M src/pkg/runtime/iface.c View 1 2 3 5 chunks +20 lines, -15 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.c View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4
r
http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c File src/pkg/runtime/iface.c (right): http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c#newcode395 src/pkg/runtime/iface.c:395: #pragma textflag 7 you can't do this - it's ...
11 years, 11 months ago (2012-04-09 07:05:54 UTC) #1
dfc
Hi Rob, Thank you for your comments. I have removed the textflag on convI2I. For ...
11 years, 11 months ago (2012-04-09 08:01:54 UTC) #2
dfc
PTAL http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c File src/pkg/runtime/iface.c (right): http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c#newcode395 src/pkg/runtime/iface.c:395: #pragma textflag 7 On 2012/04/09 07:05:54, r wrote: ...
11 years, 11 months ago (2012-04-09 08:04:07 UTC) #3
minux1
11 years, 11 months ago (2012-04-09 19:12:53 UTC) #4
http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c
File src/pkg/runtime/iface.c (right):

http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c#newco...
src/pkg/runtime/iface.c:163: t->alg->copy(size, p, src);
are you sure that the compiler will compile these better?

http://codereview.appspot.com/5798047/diff/4001/src/pkg/runtime/iface.c#newco...
src/pkg/runtime/iface.c:196: r = wid % maxround;
could we use macro functions instead? then we won't have any code duplications.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b