Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4734)

Issue 579570046: get_path_list: use loop instead of tail recursion

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by dak
Modified:
4 years ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

get_path_list: use loop instead of tail recursion

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M lily/stencil-integral.cc View 2 chunks +3 lines, -4 lines 1 comment Download

Messages

Total messages: 2
hanwenn
LGTM https://codereview.appspot.com/579570046/diff/579580044/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/579570046/diff/579580044/lily/stencil-integral.cc#newcode111 lily/stencil-integral.cc:111: for (;scm_is_pair (l); l = scm_cdr (l)) to ...
4 years ago (2020-04-17 09:12:18 UTC) #1
dak
4 years ago (2020-04-18 13:06:01 UTC) #2
On 2020/04/17 09:12:18, hanwenn wrote:
> LGTM
> 
>
https://codereview.appspot.com/579570046/diff/579580044/lily/stencil-integral.cc
> File lily/stencil-integral.cc (right):
> 
>
https://codereview.appspot.com/579570046/diff/579580044/lily/stencil-integral...
> lily/stencil-integral.cc:111: for (;scm_is_pair (l); l = scm_cdr (l))

Reformatted.  Not uploading a separate review for this one, though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b