Issue 5794079: Add option to automatically flush GrInOrderDrawBuffer based on previewing vtx/idx request sizes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5794079: Add option to automatically flush GrInOrderDrawBuffer based on previewing vtx/idx request sizes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bsalomon

Modified:
12 years, 6 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : cleanup #

Total comments: 3

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -14 lines)			Patch
src/gpu/GrContext.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
src/gpu/GrDrawTarget.h	View	1	2 chunks	+12 lines, -5 lines	0 comments	Download
src/gpu/GrDrawTarget.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
src/gpu/GrInOrderDrawBuffer.h	View	1	3 chunks	+33 lines, -6 lines	2 comments	Download
src/gpu/GrInOrderDrawBuffer.cpp	View	1	3 chunks	+40 lines, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Recommended to start with GrDrawTarget.h and then GrInOrderDrawBuffer.h.

12 years, 6 months ago (2012-03-13 13:43:39 UTC) #1

TomH

http://codereview.appspot.com/5794079/diff/2001/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (right): http://codereview.appspot.com/5794079/diff/2001/src/gpu/GrInOrderDrawBuffer.cpp#newcode444 src/gpu/GrInOrderDrawBuffer.cpp:444: // this request then we can't flush. Aha! My ...

12 years, 6 months ago (2012-03-13 13:48:06 UTC) #3

Closed with r3373.

Expand All Messages | Collapse All Messages