Issue 5786057: Prevent getting per glyph data if maxp table says 0 glyphs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5786057: Prevent getting per glyph data if maxp table says 0 glyphs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by arthurhsu

Modified:
12 years, 6 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Prevent getting per glyph data if maxp table says 0 glyphs. Fix crbug.com/117322 crash BUG=crbug.com/117322 TEST=existing

Patch Set 2 : Update per code review #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/ports/SkFontHost_win.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Steve VanDeBogart

http://codereview.appspot.com/5786057/diff/1/src/ports/SkFontHost_win.cpp File src/ports/SkFontHost_win.cpp (right): http://codereview.appspot.com/5786057/diff/1/src/ports/SkFontHost_win.cpp#newcode1103 src/ports/SkFontHost_win.cpp:1103: if (otm.otmTextMetrics.tmPitchAndFamily & TMPF_TRUETYPE) { Why not check for ...

12 years, 6 months ago (2012-03-08 19:05:31 UTC) #2

arthurhsu

12 years, 6 months ago (2012-03-08 19:14:45 UTC) #3

LGTM.  Committed in r3345

Expand All Messages | Collapse All Messages