Issue 5786043: cmd/go: workaround missing __chkstk symbol problem for ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5786043: cmd/go: workaround missing __chkstk symbol problem for ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by minux1

Modified:
13 years, 7 months ago

Reviewers:
brainman, golang-dev

CC:
golang-dev

Visibility:
Public.

Description

cmd/go: workaround missing __chkstk symbol problem for Windows Also enable misc/cgo/test on Windows.

Patch Set 1 #

Patch Set 2 : diff -r 8602e1593d53 https://code.google.com/p/go/ #

Total comments: 3

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/cmd/go/build.go	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download
	M	src/run.bat	View	1	1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

brainman

13 years, 7 months ago (2012-03-08 02:40:38 UTC) #1

It works fine on both 386 and amd64. But see my comments ...

http://codereview.appspot.com/5786043/diff/2001/src/cmd/go/build.go
File src/cmd/go/build.go (right):

http://codereview.appspot.com/5786043/diff/2001/src/cmd/go/build.go#newcode1327
src/cmd/go/build.go:1327: a = append(a, "-mno-stack-arg-probe",
"-fno-stack-check", "-fno-stack-protector")
I do not know what "-mno-stack-arg-probe", "-fno-stack-check",
"-fno-stack-protector" do but:

1) Should these be default setting for gcc compiler during cgo? If not, then you
should put them into correspondent test source file instead.

2) If you do put them into the source file they belong to, wouldn't they defeat
the purpose of the test? (remember, I do not know what these do)

http://codereview.appspot.com/5786043/diff/2001/src/run.bat
File src/run.bat (right):

http://codereview.appspot.com/5786043/diff/2001/src/run.bat#newcode42
src/run.bat:42: go test ../misc/cgo/test
You need to check if this command failed. Something like
http://codereview.appspot.com/5756065/patch/3/3003.

http://codereview.appspot.com/5786043/diff/2001/src/run.bat#newcode42
src/run.bat:42: go test ../misc/cgo/test
s:/:\:g

Expand All Messages | Collapse All Messages