Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1689)

Issue 5784057: code review 5784057: hgignore: ignoring misc/cgo/testso/main instead of /mis... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by fss
Modified:
12 years ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

hgignore: ignoring misc/cgo/testso/main instead of /misc/cgo/testso/testso test.bash does not remove main if the test fails, so it is good to keep main in .hgignore.

Patch Set 1 #

Patch Set 2 : diff -r c053986a1184 https://code.google.com/p/go #

Patch Set 3 : diff -r c053986a1184 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .hgignore View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
fss
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years ago (2012-03-08 17:28:01 UTC) #1
rsc
LGTM
12 years ago (2012-03-08 17:49:05 UTC) #2
rsc
12 years ago (2012-03-08 17:49:26 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=9974201aa263 ***

hgignore: ignoring misc/cgo/testso/main instead of /misc/cgo/testso/testso

test.bash does not remove main if the test fails, so it is good to keep main in
.hgignore.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5784057

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b