Issue 5783099: Use floats for mask table for accuracy.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5783099: Use floats for mask table for accuracy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bungeman

Modified:
12 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use floats for mask table for accuracy.

Patch Set 1 #

Patch Set 2 : Be more Skia like. #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -36 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View	1	5 chunks	+58 lines, -36 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bungeman

We only do this once for 1024 values, so I going for some accuracy here ...

12 years, 9 months ago (2012-03-13 13:54:32 UTC) #1

bungeman

12 years, 9 months ago (2012-03-13 15:43:33 UTC) #2

On 2012/03/13 13:54:32, bungeman wrote:
> We only do this once for 1024 values, so I going for some accuracy here at the
> cost of some speed. Once we're finished experimenting, some of this could be
> turned into actual tables and no calculations would be needed at runtime
anyway.
> 
> Also added an optional sRGB so we know what that looks like, and cleaned up
> which bits of code go with which defines.

Committed revision r3374.
Rebaselined revision r3375.

Expand All Messages | Collapse All Messages