Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 5783075: Doc: NR add predefined paper sizes to appendix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by pkx166h
Modified:
12 years ago
Reviewers:
dak, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR add predefined paper sizes to appendix Issue 2391 Copied predefined paper size entries from scm/paper.scm as a seperate appendix entry in order to better document predefined paper sizes

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2nd Patch - formatted table plus additions #

Total comments: 6

Patch Set 3 : Patch set 3 - Trevor's nitpicks (thanks for checking) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -39 lines) Patch
M Documentation/notation/notation-appendices.itely View 1 2 chunks +254 lines, -0 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 2 2 chunks +49 lines, -39 lines 0 comments Download
M scm/paper.scm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dak
http://codereview.appspot.com/5783075/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): http://codereview.appspot.com/5783075/diff/1/Documentation/notation/notation-appendices.itely#newcode450 Documentation/notation/notation-appendices.itely:450: @verbatim @table @code @item "a10" 26 x 37 mm ...
12 years, 1 month ago (2012-03-11 20:29:02 UTC) #1
pkx166h
My new ammended comment in the git format patch seems to not have been included ...
12 years, 1 month ago (2012-03-17 22:49:46 UTC) #2
Trevor Daniels
LGTM, James, apart from a couple of nitpicks (but I didn't check the sizes :) ...
12 years, 1 month ago (2012-03-18 17:54:02 UTC) #3
pkx166h
12 years, 1 month ago (2012-03-18 20:05:55 UTC) #4
http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):

http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacin...
Documentation/notation/spacing.itely:211: @code{set-paper-size} ,
On 2012/03/18 17:54:02, Trevor Daniels wrote:
> Drop space before comma

Done.

http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacin...
Documentation/notation/spacing.itely:219: which must always be placed in a
@code{\paper} block:
On 2012/03/18 17:54:02, Trevor Daniels wrote:
> colon -> period

Done.

http://codereview.appspot.com/5783075/diff/3001/Documentation/notation/spacin...
Documentation/notation/spacing.itely:232: @code{\paper} block.  See
@ref{Automatic scaling to paper size}.
On 2012/03/18 17:54:02, Trevor Daniels wrote:
> I don't think we need all these @emphs; too many and
> it looks like we're shouting at the reader :)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b