Issue 5783060: add/delete some comments to path renderer interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5783060: add/delete some comments to path renderer interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by guanqun

Modified:
12 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add some comments to path renderer interface BUG= TEST=

Patch Set 1 #

Total comments: 1

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -11 lines)			Patch
	M	src/gpu/GrPathRenderer.h	View		5 chunks	+35 lines, -11 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

guanqun

With the recent changes in path renderer interface, I've deleted some obsoleted comments and provide ...

12 years, 9 months ago (2012-03-09 01:59:26 UTC) #1

bsalomon

12 years, 9 months ago (2012-03-12 13:16:50 UTC) #2

On 2012/03/09 01:59:26, guanqun wrote:
> With the recent changes in path renderer interface, I've deleted some
obsoleted
> comments and provide a base for more improvements.
> 
> Thanks! Please review.
> 
> http://codereview.appspot.com/5783060/diff/1/src/gpu/GrPathRenderer.h
> File src/gpu/GrPathRenderer.h (left):
> 
>
http://codereview.appspot.com/5783060/diff/1/src/gpu/GrPathRenderer.h#oldcode63
> src/gpu/GrPathRenderer.h:63: * before setPath/drawPath is called and so
> shouldn't be considered.
> We're not supposed to get different render target at 'canDrawPath' and
> 'drawPath', right?

Thanks for the cleanup! I submitted (with some very minor mods) at r3361.

You're correct that we should not see a different target. There is an assert in
drawPath() that calls canDrawPath().

Expand All Messages | Collapse All Messages