Issue 5781059: use floats to compute texture matrix / coords

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5781059: use floats to compute texture matrix / coords (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bsalomon

Modified:
12 years, 6 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : mroe #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/gpu/SkGpuDevice.cpp	View	1	2 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

lgtm I think its cute we use SkFloatToScalar(), as if scalar could be anything other ...

12 years, 6 months ago (2012-03-08 19:48:28 UTC) #2

bsalomon

On 2012/03/08 19:48:28, reed1 wrote: > lgtm > > I think its cute we use ...

12 years, 6 months ago (2012-03-08 19:51:21 UTC) #3

reed1

12 years, 6 months ago (2012-03-08 19:59:07 UTC) #5

On 2012/03/08 19:51:21, bsalomon wrote:
> On 2012/03/08 19:48:28, reed1 wrote:
> > lgtm
> > 
> > I think its cute we use SkFloatToScalar(), as if scalar could be anything
> other
> > than float :)
> 
> double? :)

touché

Expand All Messages | Collapse All Messages