Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(754)

Issue 577820043: Build slur skyline out of segments rather than boxes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hanwenn
Modified:
3 years, 10 months ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Build slur skyline out of segments rather than boxes.

Patch Set 1 #

Total comments: 2

Patch Set 2 : jonas. #

Patch Set 3 : jonas #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M lily/slur.cc View 1 2 3 1 chunk +14 lines, -10 lines 0 comments Download

Messages

Total messages: 5
hahnjo
https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc File lily/slur.cc (right): https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc#newcode380 lily/slur.cc:380: vector<Box> boxes; Please move vector<Drul_array<Offset>> segments here and use ...
3 years, 11 months ago (2020-04-27 06:52:52 UTC) #1
hanwenn
jonas.
3 years, 11 months ago (2020-04-27 21:35:19 UTC) #2
hanwenn
jonas
3 years, 11 months ago (2020-04-27 21:46:14 UTC) #3
hanwenn
rebase
3 years, 11 months ago (2020-05-01 07:09:54 UTC) #4
hanwenn
3 years, 11 months ago (2020-05-01 07:10:13 UTC) #5
rebase
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b