Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1296)

Issue 5777053: Fix make error in regression tests coming from midi2ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by Carl
Modified:
12 years ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix make error in regression tests coming from midi2ly I have been unable to complete make test-baseline because of errors in the files coming from midi2ly.py. I tracked the error to make/midi-rules.make. The change in this patch allows me to successfully complete make test-baseline on my computer, running OSX 10.5.8, with GNU Make 3.81.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change command to avoid intermediate newline #

Patch Set 3 : Use printf instead of echo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M make/midi-rules.make View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
dak
http://codereview.appspot.com/5777053/diff/1/make/midi-rules.make File make/midi-rules.make (right): http://codereview.appspot.com/5777053/diff/1/make/midi-rules.make#newcode12 make/midi-rules.make:12: (echo '\header {'; for f in $(HEADER_FIELDS); do echo ...
12 years ago (2012-03-10 19:20:31 UTC) #1
Carl
12 years ago (2012-03-10 20:28:29 UTC) #2
On 2012/03/10 19:20:31, dak wrote:

> (I am surprised that your shell had a version of echo not
> understanding -n).
> 

I am, too.  My bash shell has echo that understands -n, so I expected it to
work.

I'll see what I can figure out to make it work.

Thanks,

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b