Issue 577130043: add suggestAccidentals = #'cautionary option

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 577130043: add suggestAccidentals = #'cautionary option

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 5 months ago by Malte Meyn

Modified:
4 years, 4 months ago

Reviewers:
Dan Eble, lemzwerg, carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

add suggestAccidentals = #'cautionary option Setting suggestAccidentals to 'cautionary now prints only cautionary accidentals (input by ?) as AccidentalSuggestion.

Patch Set 1 #

Patch Set 2 : add changes entry (untested, see mail on lilypond-devel) #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -13 lines)			Patch
M	Documentation/changes.tely	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	input/regression/accidental-suggestions.ly	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	lily/accidental-engraver.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	scm/define-context-properties.scm	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Carl

Very nice. I think there should be a changes.tely entry. Carl

4 years, 5 months ago (2019-11-21 14:31:42 UTC) #3

Carl

Very nice. I think there should be a changes.tely entry. Carl

4 years, 5 months ago (2019-11-21 14:31:42 UTC) #4

Malte Meyn

On 2019/11/21 14:31:42, Carl wrote: > Very nice. > > I think there should be ...

4 years, 5 months ago (2019-11-22 12:54:52 UTC) #5

Malte Meyn

4 years, 4 months ago (2019-11-23 11:25:09 UTC) #6

add changes entry (untested, see mail on lilypond-devel)

Expand All Messages | Collapse All Messages