Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(255)

Issue 576610043: Avoid some crashes for bad "control-points" property (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by dak
Modified:
4 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Avoid some crashes for bad "control-points" property

Patch Set 1 #

Patch Set 2 : Fix slur configuration too (thanks, Han-Wen) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M lily/slur.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M lily/slur-configuration.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M lily/tie.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9
thomasmorley651
As always, I can't review C++. So let me ask, how will LilyPond react seeing ...
4 years, 11 months ago (2019-04-25 21:29:18 UTC) #1
dak
thomasmorley65@gmail.com writes: > As always, I can't review C++. > > So let me ask, ...
4 years, 11 months ago (2019-04-25 23:27:29 UTC) #2
benko.pal
LGTM
4 years, 11 months ago (2019-04-26 18:10:21 UTC) #3
hanwenn
add a regression test?
4 years, 11 months ago (2019-04-26 18:24:49 UTC) #4
dak
hanwenn@gmail.com writes: > add a regression test? > > https://codereview.appspot.com/576610043/ I am not sure what ...
4 years, 11 months ago (2019-04-26 18:49:03 UTC) #5
hanwenn
On 2019/04/26 18:49:03, dak wrote: > mailto:hanwenn@gmail.com writes: > > > add a regression test? ...
4 years, 11 months ago (2019-04-28 18:07:48 UTC) #6
dak
hanwenn@gmail.com writes: > On 2019/04/26 18:49:03, dak wrote: >> mailto:hanwenn@gmail.com writes: > >> > add ...
4 years, 11 months ago (2019-04-28 18:32:03 UTC) #7
dak
Fix slur configuration too (thanks, Han-Wen)
4 years, 11 months ago (2019-04-28 19:14:53 UTC) #8
thomasmorley651
4 years, 11 months ago (2019-04-30 21:23:20 UTC) #9
On 2019/04/28 19:14:53, dak wrote:
> Fix slur configuration too (thanks, Han-Wen)

I've downloaded you're patch. After playing around with it: all seems to work
nicely, no glitch found.
Thus, from testing:
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b