|
|
Descriptiontest: actually run them on windows
Patch Set 1 #Patch Set 2 : diff -r df3c38a88655 https://go.googlecode.com/hg/ #Patch Set 3 : diff -r df3c38a88655 https://go.googlecode.com/hg/ #Patch Set 4 : diff -r c2433a6f3abe https://go.googlecode.com/hg/ #Patch Set 5 : diff -r 90d7825be7c2 https://go.googlecode.com/hg/ #MessagesTotal messages: 13
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
Sign in to reply to this message.
This CL will break windows build, because of # test errorcheck import5.go : Multiple errors: errchk: import5.go:54: error(s) on line didn't match pattern: import path cannot be absolute path errchk: import5.go:55: missing expected error: import path contains invalid character exit status 1
Sign in to reply to this message.
On Mar 7, 2012, at 12:21 PM, alex.brainman@gmail.com wrote: > This CL will break windows build, because of > > # test > errorcheck import5.go : Multiple errors: > errchk: import5.go:54: error(s) on line didn't match pattern: import > path cannot be absolute path > errchk: import5.go:55: missing expected error: import path contains > invalid character > > exit status 1 > > http://codereview.appspot.com/5756065/ for the record, these are import "/foo" // ERROR "import path cannot be absolute path" import "c:/foo" // ERROR "import path contains invalid character"
Sign in to reply to this message.
On Tue, Mar 6, 2012 at 20:21, <alex.brainman@gmail.com> wrote: > errorcheck import5.go : Multiple errors: > errchk: import5.go:54: error(s) on line didn't match pattern: import > path cannot be absolute path > errchk: import5.go:55: missing expected error: import path contains > invalid character This is not a very useful error. Brad, I am not sure I follow the logic in run.go, but should the 'didn't match pattern' error also print the contents of out? Russ
Sign in to reply to this message.
On Tue, Mar 6, 2012 at 7:03 PM, Russ Cox <rsc@golang.org> wrote: > On Tue, Mar 6, 2012 at 20:21, <alex.brainman@gmail.com> wrote: > > errorcheck import5.go : Multiple errors: > > errchk: import5.go:54: error(s) on line didn't match pattern: import > > path cannot be absolute path > > errchk: import5.go:55: missing expected error: import path contains > > invalid character > > This is not a very useful error. > > Brad, I am not sure I follow the logic in run.go, but > should the 'didn't match pattern' error also print the > contents of out? I'll take a look later this evening or early tomorrow morning. Have to run shortly here.
Sign in to reply to this message.
Do we still want to fix this? Alex
Sign in to reply to this message.
Oh, it's not? I woke up to a bunch of patches which made it look like it was. On Thu, Mar 8, 2012 at 5:32 PM, <alex.brainman@gmail.com> wrote: > Do we still want to fix this? > > Alex > > http://codereview.appspot.com/**5756065/<http://codereview.appspot.com/5756065/> >
Sign in to reply to this message.
On 2012/03/09 01:36:01, bradfitz wrote: > Oh, it's not? ... > No, tests are still not running on windows. This CL fixes that. But this CL will break windows build, because of # test errorcheck import5.go : Multiple errors: errchk: import5.go:54: error(s) on line didn't match pattern: import path cannot be absolute path errchk: import5.go:55: missing expected error: import path contains invalid character exit status 1 So we need to fix problem with import5.go before we submit this current CL. Should I look why import5.go fails? I suspect, it is in compiler, and it might take me a while. Alex
Sign in to reply to this message.
On Fri, Mar 9, 2012 at 9:42 AM, <alex.brainman@gmail.com> wrote: > No, tests are still not running on windows. This CL fixes that. But this > > CL will break windows build, because of > > # test > errorcheck import5.go : Multiple errors: > errchk: import5.go:54: error(s) on line didn't match pattern: import > path cannot > be absolute path > errchk: import5.go:55: missing expected error: import path contains > invalid > character > > exit status 1 > > So we need to fix problem with import5.go before we submit this current > CL. > > Should I look why import5.go fails? I suspect, it is in compiler, and it > might take me a while. > http://codereview.appspot.com/5784065
Sign in to reply to this message.
LGTM but put the @echo off back. When this breaks the build, we can fix it. :-)
Sign in to reply to this message.
On 2012/03/09 19:25:58, rsc wrote: > LGTM but put the @echo off back. > Done. But now some tests break (I am using different computer now): # test run gc.go : incorrect output mkdir C:\Users\Alex\AppData\Local\Temp\go-build323532790: Cannot create a file when that file already exists. run ken\cplx0.go : incorrect output mkdir C:\Users\Alex\AppData\Local\Temp\go-build236156350: Cannot create a file when that file already exists. run ken\ptrfun.go : incorrect output mkdir C:\Users\Alex\AppData\Local\Temp\go-build283210606: Cannot create a file when that file already exists. run fixedbugs\bug002.go : incorrect output mkdir C:\Users\Alex\AppData\Local\Temp\go-build782089890: Cannot create a file when that file already exists. run fixedbugs\bug292.go : incorrect output mkdir C:\Users\Alex\AppData\Local\Temp\go-build163053286: Cannot create a file when that file already exists. exit status 1 I need to investigate more. Alex
Sign in to reply to this message.
On 2012/03/09 23:01:10, brainman wrote: > Done. But now some tests break (I am using different computer now): > > # test > run gc.go : incorrect output > mkdir C:\Users\Alex\AppData\Local\Temp\go-build323532790: Cannot create a file > when that file already exists. > > run ken\cplx0.go : incorrect output > mkdir C:\Users\Alex\AppData\Local\Temp\go-build236156350: Cannot create a file > when that file already exists. > > run ken\ptrfun.go : incorrect output > mkdir C:\Users\Alex\AppData\Local\Temp\go-build283210606: Cannot create a file > when that file already exists. > > run fixedbugs\bug002.go : incorrect output > mkdir C:\Users\Alex\AppData\Local\Temp\go-build782089890: Cannot create a file > when that file already exists. > > run fixedbugs\bug292.go : incorrect output > mkdir C:\Users\Alex\AppData\Local\Temp\go-build163053286: Cannot create a file > when that file already exists. > > exit status 1 http://codereview.appspot.com/5754083/
Sign in to reply to this message.
*** Submitted as http://code.google.com/p/go/source/detail?r=b78a69fcf693 *** test: actually run them on windows R=golang-dev, r, rsc, bradfitz, minux.ma CC=golang-dev http://codereview.appspot.com/5756065
Sign in to reply to this message.
|