Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1985)

Issue 575600044: Issue 2173: Add Unicode filename support for Windows 10 1903+

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by trueroad
Modified:
4 years, 3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add Unicode filename support for Windows 10 1903+ On Windows 10 1903 and above, -A APIs support UTF-8 encodings. This commit enables it by adding an application manifest. https://docs.microsoft.com/en-us/windows/uwp/design/globalizing/use-utf8-code-page If you use older Windows, it has no effect and the behavior is the same as before. For Cygwin environments, UTF-8 can be used originally, so this commit doesn't add the application manifest.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M lily/GNUmakefile View 1 chunk +2 lines, -1 line 0 comments Download
A lily/lilypond.manifest View 1 chunk +9 lines, -0 lines 0 comments Download
M lily/lilypond.rc.in View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
Very nice, thanks! LGTM
4 years, 3 months ago (2020-02-01 18:49:56 UTC) #1
trueroad
4 years, 3 months ago (2020-02-04 12:23:24 UTC) #2
I've pushed.

commit    62635fe1155fba0c91569d6785906100a8f2e88c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b