Issue 575600043: Inline assembler fallback for _FPU_SETCW() missing in x86 platforms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 575600043: Inline assembler fallback for _FPU_SETCW() missing in x86 platforms (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by thomasmorley651

Modified:
4 years, 2 months ago

Reviewers:
arnold.wendl

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Inline assembler fallback for _FPU_SETCW() missing in x86 platforms Issue 4943 As Issue 4943 on x86 platform compilations was triggered by missing _FPU_SETCW(), an alternate call to initiate the X87 FPU setup as an inline-assembler command is added.

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	lily/main.cc	View		1 chunk	+26 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thomasmorley651

This adds Masamichi-san's suggestions from https://codereview.appspot.com/577450043/ Comment #7 Sorry, for the new issue, initiated by ...

4 years, 2 months ago (2020-02-01 00:52:15 UTC) #1

thomasmorley651

4 years, 2 months ago (2020-02-16 11:04:54 UTC) #2

On 2020/02/01 00:52:15, thomasmorley651 wrote:
> This adds Masamichi-san's suggestions from
> https://codereview.appspot.com/577450043/
> Comment #7
> Sorry, for the new issue, initiated by accident
> 
> This does _not_ reflect the discussion of
> https://lists.gnu.org/archive/html/lilypond-devel/2020-01/msg00845.html
> It's out of my depth.

Superseded by
https://codereview.appspot.com/565600045
Closing this one

Expand All Messages | Collapse All Messages