GUILE2: generate internals doc in UTF-8

GUILE2: generate internals doc in UTF-8

Otherwise, GUILE guesses Latin-1 leading to:

  $ isutf8 internals.texi 
  internals.texi: line 20310, char 1, byte offset 50: invalid UTF-8 code

[dak, 2020-01-24 11:08:52]

https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
File scm/documentation-generate.scm (right):

https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
scm/documentation-generate.scm:98: (if (defined? 'set-port-encoding!)
I think we usually do this as

(if (guile-v2) ...

in order to better be able to find dependencies and ultimately (after migration)
throw them out.  Also I am not sure that the byte-compiler is happy about those
constructs.

[hanwenn, 2020-01-24 11:14:49]

(guile-v2)

[hanwenn, 2020-01-24 11:15:10]

https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
File scm/documentation-generate.scm (right):

https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
scm/documentation-generate.scm:98: (if (defined? 'set-port-encoding!)
On 2020/01/24 11:08:51, dak wrote:
> I think we usually do this as
> 
> (if (guile-v2) ...
> 
> in order to better be able to find dependencies and ultimately (after
migration)
> throw them out.  Also I am not sure that the byte-compiler is happy about
those
> constructs.

Done.

[hanwenn, 2020-01-27 08:23:41]

On 2020/01/24 11:15:10, hanwenn wrote:
>
https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
> File scm/documentation-generate.scm (right):
> 
>
https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
> scm/documentation-generate.scm:98: (if (defined? 'set-port-encoding!)
> On 2020/01/24 11:08:51, dak wrote:
> > I think we usually do this as
> > 
> > (if (guile-v2) ...
> > 
> > in order to better be able to find dependencies and ultimately (after
> migration)
> > throw them out.  Also I am not sure that the byte-compiler is happy about
> those
> > constructs.
> 
> Done.

ping.

[dak, 2020-01-27 09:51:39]

On 2020/01/27 08:23:41, hanwenn wrote:
> On 2020/01/24 11:15:10, hanwenn wrote:
> >
>
https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
> > File scm/documentation-generate.scm (right):
> > 
> >
>
https://codereview.appspot.com/575540045/diff/571410043/scm/documentation-gen...
> > scm/documentation-generate.scm:98: (if (defined? 'set-port-encoding!)
> > On 2020/01/24 11:08:51, dak wrote:
> > > I think we usually do this as
> > > 
> > > (if (guile-v2) ...
> > > 
> > > in order to better be able to find dependencies and ultimately (after
> > migration)
> > > throw them out.  Also I am not sure that the byte-compiler is happy about
> > those
> > > constructs.
> > 
> > Done.
> 
> ping.

I now set status of issue #5683 back to Patch-new to trigger retesting.  If you
submit followup patches via git-cl, that should happen automatically.