Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1006)

Issue 575540044: Provide --loglevel=PROGRESS for make VERBOSE=1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by hanwenn
Modified:
4 years, 2 months ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Provide --loglevel=PROGRESS for make VERBOSE=1 This provides enough information to diagnose problems in included files while building the documentation.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M make/lilypond-vars.make View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
> This provides enough information to diagnose problems in included > files while building the ...
4 years, 3 months ago (2020-01-27 02:52:44 UTC) #1
hanwenn
4 years, 3 months ago (2020-01-27 08:28:01 UTC) #2
On 2020/01/27 02:52:44, Dan Eble wrote:
> > This provides enough information to diagnose problems in included
> > files while building the documentation.
> 
> LGTM, though I wonder why these problems (whatever they are) do not trigger
> useful diagnostic messages at WARN or higher levels, which would be seen even
at
> the default verbosity level.  In other words, is this change just working
around
> deficiencies of the program?

kind of. If there is a problem with an input file, the progress messages would
tell you what
the last file processed was. 

The clean way to do this, is to catch the exception in python, annotate it with
the current file
and rethrow. It's more work, and this gets it done well enough for debugging.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b