Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 5754083: code review 5754083: os, syscall: windows really isn't posix compliant, fix ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by minux1
Modified:
12 years ago
Reviewers:
CC:
golang-dev, rsc, bradfitz, brainman
Visibility:
Public.

Description

os, syscall: windows really isn't posix compliant, fix os.IsExist()

Patch Set 1 #

Patch Set 2 : diff -r a2b50fa70cd7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b26cfc77a66c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7dac9470d5d8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
M src/pkg/os/error_posix.go View 1 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/os/error_test.go View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A src/pkg/os/error_windows.go View 1 1 chunk +35 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2012-03-12 06:03:56 UTC) #1
rsc
LGTM but please wait for Alex to okay it too.
12 years ago (2012-03-12 16:59:12 UTC) #2
bradfitz
Again we have documentation duplicated in multiple files. :-/ On Sun, Mar 11, 2012 at ...
12 years ago (2012-03-12 17:00:45 UTC) #3
minux1
On 2012/03/12 17:00:45, bradfitz wrote: > Again we have documentation duplicated in multiple files. :-/ ...
12 years ago (2012-03-12 19:51:57 UTC) #4
bradfitz
On Mon, Mar 12, 2012 at 12:51 PM, <minux.ma@gmail.com> wrote: > On 2012/03/12 17:00:45, bradfitz ...
12 years ago (2012-03-12 19:55:35 UTC) #5
minux1
On Tue, Mar 13, 2012 at 3:55 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > > We can ...
12 years ago (2012-03-12 20:13:31 UTC) #6
brainman
LGTM. Thank you. I will submit it now. Alex
12 years ago (2012-03-13 01:49:28 UTC) #7
brainman
12 years ago (2012-03-13 01:50:11 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=90d7825be7c2 ***

os, syscall: windows really isn't posix compliant, fix os.IsExist()

R=golang-dev, rsc, bradfitz, alex.brainman
CC=golang-dev
http://codereview.appspot.com/5754083

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b