Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 5754074: Doc: NR: Polyphony - use voiceX not \xxxup/down (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by pkx166h
Modified:
12 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR: Polyphony - use voiceX not \xxxup/down Issue 2388 NR 5.4.2 Explain that it is preferable to use \VoiceOne/Two etc, instead of \xxxUp/Down/Neutral to specify object direction. Added @seealso section, some inconsistency in syntax and formatting cleaned up.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch 2 - TD's Nitpick. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -19 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 chunks +28 lines, -19 lines 1 comment Download

Messages

Total messages: 4
Trevor Daniels
LGTM, bar a nitpick. Trevor http://codereview.appspot.com/5754074/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5754074/diff/1/Documentation/notation/changing-defaults.itely#newcode2322 Documentation/notation/changing-defaults.itely:2322: @code{voice} than changing an ...
12 years ago (2012-03-11 15:27:56 UTC) #1
pkx166h
new patch uploaded http://codereview.appspot.com/5754074/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5754074/diff/1/Documentation/notation/changing-defaults.itely#newcode2322 Documentation/notation/changing-defaults.itely:2322: @code{voice} than changing an object's direction. ...
12 years ago (2012-03-11 19:11:42 UTC) #2
janek
LGTM
12 years ago (2012-03-11 19:47:57 UTC) #3
Graham Percival
12 years ago (2012-03-12 20:43:05 UTC) #4
http://codereview.appspot.com/5754074/diff/3001/Documentation/notation/changi...
File Documentation/notation/changing-defaults.itely (right):

http://codereview.appspot.com/5754074/diff/3001/Documentation/notation/changi...
Documentation/notation/changing-defaults.itely:2289: @code{\xxxUp},
@code{\xxxDown} or @code{\xxxNeutral}
I think this should be in an @example, but that's a minor point.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b