Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2668)

Issue 5753073: make pathrenderers release their geometry before returning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by bsalomon
Modified:
12 years, 4 months ago
Reviewers:
TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 3 chunks +14 lines, -10 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 4 chunks +16 lines, -16 lines 1 comment Download

Messages

Total messages: 4
bsalomon
The GrPathRenderer interface is back to a one-shot model now that the supersampling code is ...
12 years, 4 months ago (2012-03-07 19:00:57 UTC) #1
bsalomon
12 years, 4 months ago (2012-03-07 19:01:06 UTC) #2
TomH
LGTM. I'd like to understand "one-shot model", however. http://codereview.appspot.com/5753073/diff/1/src/gpu/GrDefaultPathRenderer.cpp File src/gpu/GrDefaultPathRenderer.cpp (right): http://codereview.appspot.com/5753073/diff/1/src/gpu/GrDefaultPathRenderer.cpp#newcode248 src/gpu/GrDefaultPathRenderer.cpp:248: base ...
12 years, 4 months ago (2012-03-07 19:05:23 UTC) #3
bsalomon
12 years, 4 months ago (2012-03-07 19:15:57 UTC) #4
Committed w/ nit fix at 3335. (One-shot means drawPath() takes a path param,
draws it, forgets it. The interface used to allow setPath(), drawPath(),
drawPath(), ... , clearPath())
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b