code review 5753048: net: add skip message to test

net: add skip message to test

[mikio, 2012-03-06 06:11:48]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-06 06:18:05]

LGTM

but %s probably is fine. runtime.GOOS won't have sketchy contents, which is
where %q comes in useful. either way.

On Mon, Mar 5, 2012 at 10:11 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: add skip message to test
>
> Please review this at
http://codereview.appspot.com/**5753048/<http://codereview.appspot.com/5753048/>
>
> Affected files:
>  M src/pkg/net/multicast_test.go
>  M src/pkg/net/net_test.go
>  M src/pkg/net/parse_test.go
>  M src/pkg/net/server_test.go
>  M src/pkg/net/timeout_test.go
>  M src/pkg/net/udp_test.go
>  M src/pkg/net/unicast_test.go
>
>
> Index: src/pkg/net/multicast_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/multicast_test.**go
> +++ b/src/pkg/net/multicast_test.**go
> @@ -47,9 +47,11 @@
>  func TestMulticastListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "netbsd", "openbsd", "plan9", "windows":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        case "linux":
>                if runtime.GOARCH == "arm" || runtime.GOARCH == "alpha" {
> +                       t.Logf("skipping test on %q/%q", runtime.GOOS,
> runtime.GOARCH)
>                        return
>                }
>        }
> @@ -86,6 +88,7 @@
>  func TestSimpleMulticastListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> Index: src/pkg/net/net_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/net_test.go
> +++ b/src/pkg/net/net_test.go
> @@ -21,6 +21,7 @@
>
>  func TestShutdown(t *testing.T) {
>        if runtime.GOOS == "plan9" {
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>        l, err := Listen("tcp", "127.0.0.1:0")
> Index: src/pkg/net/parse_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/parse_test.go
> +++ b/src/pkg/net/parse_test.go
> @@ -13,7 +13,9 @@
>
>  func TestReadLine(t *testing.T) {
>        // /etc/services file does not exist on windows and Plan 9.
> -       if runtime.GOOS == "windows" || runtime.GOOS == "plan9" {
> +       switch runtime.GOOS {
> +       case "plan9", "windows":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>        filename := "/etc/services" // a nice big file
> Index: src/pkg/net/server_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/server_test.go
> +++ b/src/pkg/net/server_test.go
> @@ -142,6 +142,7 @@
>
>  func TestSeqpacketConnServer(t *testing.T) {
>        if runtime.GOOS != "linux" {
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> Index: src/pkg/net/timeout_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/timeout_test.go
> +++ b/src/pkg/net/timeout_test.go
> @@ -57,7 +57,9 @@
>  }
>
>  func TestTimeoutUDP(t *testing.T) {
> -       if runtime.GOOS == "plan9" {
> +       switch runtime.GOOS {
> +       case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> @@ -73,7 +75,9 @@
>  }
>
>  func TestTimeoutTCP(t *testing.T) {
> -       if runtime.GOOS == "plan9" {
> +       switch runtime.GOOS {
> +       case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> @@ -88,7 +92,9 @@
>  }
>
>  func TestDeadlineReset(t *testing.T) {
> -       if runtime.GOOS == "plan9" {
> +       switch runtime.GOOS {
> +       case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>        ln, err := Listen("tcp", "127.0.0.1:0")
> Index: src/pkg/net/udp_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/udp_test.go
> +++ b/src/pkg/net/udp_test.go
> @@ -10,7 +10,9 @@
>  )
>
>  func TestWriteToUDP(t *testing.T) {
> -       if runtime.GOOS == "plan9" {
> +       switch runtime.GOOS {
> +       case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> Index: src/pkg/net/unicast_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/unicast_test.go
> +++ b/src/pkg/net/unicast_test.go
> @@ -45,6 +45,7 @@
>  func TestTCPListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9", "windows":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> @@ -80,6 +81,7 @@
>  func TestUDPListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9", "windows":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> @@ -125,6 +127,7 @@
>  func TestSimpleTCPListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> @@ -150,6 +153,7 @@
>  func TestSimpleUDPListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>
> @@ -255,6 +259,7 @@
>  func TestDualStackTCPListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>        if !supportsIPv6 {
> @@ -291,6 +296,7 @@
>  func TestDualStackUDPListener(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>        if !supportsIPv6 {
> @@ -521,6 +527,7 @@
>  func TestProhibitionaryDialArgs(t *testing.T) {
>        switch runtime.GOOS {
>        case "plan9":
> +               t.Logf("skipping test on %q", runtime.GOOS)
>                return
>        }
>        // This test requires both IPv6 and IPv6 IPv4-mapping functionality.
>
>
>

[mikio, 2012-03-06 06:38:51]

On Tue, Mar 6, 2012 at 3:18 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> but %s probably is fine. runtime.GOOS won't have sketchy contents, which is
> where %q comes in useful. either way.

Well, just preparing the case when my app pollutes addressing space. ;)

[mikio, 2012-03-06 06:41:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=22111b8f44af ***

net: add skip message to test

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5753048