Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1109)

Issue 5734044: Tag some overridden methods with SK_OVERRIDE in SkOSWindow_Unix.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by tfarina1
Modified:
12 years, 4 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Tag some overridden methods with SK_OVERRIDE in SkOSWindow_Unix.h BUG=319 R=tomhudson@google.com Signed-off-by: Thiago Farina <tfarina@chromium.org> Committed: http://code.google.com/p/skia/source/detail?r=3318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M include/views/SkOSWindow_Unix.h View 3 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 4
tfarina1
Hi Tom, could you review this to me?
12 years, 4 months ago (2012-03-05 01:22:13 UTC) #1
TomH
LGTM. Thanks for cleaning up after us! Do you have commit rights, or shall I ...
12 years, 4 months ago (2012-03-05 12:08:59 UTC) #2
tfarina1
On 2012/03/05 12:08:59, TomH wrote: > LGTM. > > Thanks for cleaning up after us! ...
12 years, 4 months ago (2012-03-05 12:26:54 UTC) #3
TomH
12 years, 4 months ago (2012-03-05 18:29:58 UTC) #4
Committed in r3318.
Please close the issue when you get a chance.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b