Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(930)

Issue 573160047: Issue 5578: add a button to flip between old and new regtest images (take 2) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Dan Eble
Modified:
4 years, 4 months ago
Reviewers:
thaovy231011, dak, GiandomenicoFisichella, thuythuy9171, Yannini, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5578/ This is a resubmission of 911788f173eb58438fc9c850a005638d053b8bba minus the use of "tidy" to check the generated HTML. The previous code review is https://codereview.appspot.com/566920043/ * * * If JavaScript is enabled, a "Flip" button appears under the right-hand image. While the button is held down, the right-hand image is replaced by the left-hand image. Flipping back and forth can make small differences more obvious than static highlighting does. The output-distance script used to use HTML tags that are unsupported in HTML5, such as <tt> and <font>. The new approach uses CSS for general styling as well as for the flipping feature. The new style is not exactly the same as before, but should look familiar. The style sheet also includes a dark color scheme which newer browsers may select based on user preference.

Patch Set 1 #

Total comments: 2

Patch Set 2 : revise for Python 2.4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -62 lines) Patch
M scripts/build/output-distance.py View 1 12 chunks +168 lines, -62 lines 0 comments Download

Messages

Total messages: 12
Dan Eble
4 years, 5 months ago (2019-10-29 15:15:46 UTC) #1
hahnjo
This does not work as-is with Python 2.4.6. https://codereview.appspot.com/573160047/diff/581230043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/573160047/diff/581230043/scripts/build/output-distance.py#newcode424 scripts/build/output-distance.py:424: class_attr2 ...
4 years, 5 months ago (2019-10-29 18:57:37 UTC) #2
Dan Eble
On 2019/10/29 18:57:37, hahnjo wrote: > This does not work as-is with Python 2.4.6. This ...
4 years, 5 months ago (2019-10-29 19:13:51 UTC) #3
hahnjo
On 2019/10/29 19:13:51, Dan Eble wrote: > On 2019/10/29 18:57:37, hahnjo wrote: > > This ...
4 years, 5 months ago (2019-10-29 19:38:39 UTC) #4
Dan Eble
On 2019/10/29 19:38:39, hahnjo wrote: > Anyway, for now building the "latest" Python 2.4.6 is ...
4 years, 5 months ago (2019-10-29 22:00:09 UTC) #5
dak
On 2019/10/29 22:00:09, Dan Eble wrote: > On 2019/10/29 19:38:39, hahnjo wrote: > > Anyway, ...
4 years, 5 months ago (2019-10-29 22:53:17 UTC) #6
Dan Eble
revise for Python 2.4
4 years, 5 months ago (2019-10-30 03:40:00 UTC) #7
thuythuy9171
On 2019/10/30 03:40:00, Dan Eble wrote: > <font style="vertical-align: inherit;"><font style="vertical-align: inherit;">sửa lại cho Python ...
4 years, 5 months ago (2019-10-30 16:23:06 UTC) #8
Yannini
On 2019/10/30 16:23:06, thuythuy9171 wrote: > <font style="vertical-align: inherit;"><font style="vertical-align: inherit;">Vào 2019/10/30 03:40:00, Dan Eble ...
4 years, 5 months ago (2019-10-31 11:06:18 UTC) #9
Yannini
On 2019/10/29 15:15:46, Dan Eble wrote:
4 years, 5 months ago (2019-10-31 11:06:42 UTC) #10
Thaovy231011
4 years, 4 months ago (2019-11-03 04:43:04 UTC) #11
GiandomenicoFisichella
4 years, 4 months ago (2019-11-03 07:42:57 UTC) #12
On 2019/11/03 04:43:04, Thaovy231011 wrote:
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b