Issue 573042: fixes for gcc-4.4.2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 573042: fixes for gcc-4.4.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by clifford.stein

Modified:
13 years, 3 months ago

Reviewers:
dev-osl, osl-dev, ckulla

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Here are some fixes to get OSL to compile with gcc-4.4.2. Some of these fixes I shamelessly lifted from Chris.F's patch from a while back. It's mostly pretty straightforward. I've added support for unordered_map/sets if the compiler is new enough. I'm not sure if this is the way we want to proceed because it's rather verbose/ugly (should I use a #define instead?). Maybe once we upgrade to something more recent than our archaic compiler and boost library then we can clean this up properly?

Patch Set 1 #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+88 lines, -19 lines)			Patch
site/spi/Makefile-bits	View	3 chunks	+23 lines, -2 lines	0 comments	Download
src/liboslcomp/symtab.h	View	2 chunks	+23 lines, -2 lines	0 comments	Download
src/liboslexec/bsdf_cloth.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/liboslexec/bsdf_cloth_specular.cpp	View	2 chunks	+10 lines, -10 lines	0 comments	Download
src/liboslexec/context.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
src/liboslexec/exec.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
src/liboslexec/instance.cpp	View	2 chunks	+7 lines, -0 lines	0 comments	Download
src/liboslexec/oslops.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
src/oslc/oslcmain.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/oslinfo/oslinfo.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
src/testshade/simplerend.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

clifford.stein

On 2010/03/16 23:20:46, clifford.stein wrote: > One important note: I'm getting a failure in the ...

14 years, 1 month ago (2010-03-16 23:26:51 UTC) #2

Chris Foster

14 years, 1 month ago (2010-03-16 23:58:33 UTC) #4

On Wed, Mar 17, 2010 at 9:20 AM,  <clifford.stein@gmail.com> wrote:
> Description:
> Here are some fixes to get OSL to compile with gcc-4.4.2.  Some of these
> fixes I shamelessly lifted from Chris.F's patch from a while back.  It's
> mostly pretty straightforward.

LGTM2.  Good to see the patch I posted a while back wasn't too moldy
to be slightly helpful :)

Expand All Messages | Collapse All Messages